Less noise (and a bugfix)

bin/installbfa.sh

@@ -38,8 +38,10 @@ function runasownerof
     fi
     unset path
     ${precmd} "$@"
+    rv=$?
     popd > /dev/null
     unset precmd
+    return $rv
 }
 
 # For getting a recent nodejs
@@ -62,25 +64,22 @@ function nodejsinstall
     fi
     # nodejs also provides npm
     aptinstall nodejs
-}
-
-function web3install
-{
+    # init npm
     test -r ~bfa/package.json ||
         info "Initialising nodejs." &&
         runasownerof ~bfa npm init -y
     # nodejs package(s) that we need.
-    if ! runasownerof ~bfa npm ls require
+    if ! runasownerof ~bfa npm ls require > /dev/null
     then
         info "Installing nodejs module: require"
         runasownerof ~bfa npm install require
     fi
-    if ! runasownerof ~bfa npm ls request
+    if ! runasownerof ~bfa npm ls request > /dev/null
     then
         info "Installing nodejs module: request"
         runasownerof ~bfa npm install request
     fi
-    if ! runasownerof ~bfa npm ls web3
+    if ! runasownerof ~bfa npm ls web3 > /dev/null
     then
     	info "Installing nodejs module: web3 (will show many warnings)"
     	runasownerof ~bfa npm install web3
@@ -261,7 +260,6 @@ aptinstall dirmngr apt-transport-https curl git curl build-essential sudo
 aptinstall jq libjson-perl libwww-perl libclass-accessor-perl
 userconfig
 nodejsinstall
-web3install
 golanginstall
 gethinstall
 cronit