Trying to make us a nifty lib

create.contract

 #!/bin/bash
 
+cd $( dirname $0 )
+. ./libbfa.sh
+
 function	prereq
 {
 	err=0
@@ -15,25 +18,26 @@ function	prereq
 	test $err -eq 0 || exit 1
 }
 
-function	cleanup
-{
-	rmfiles="$rmfiles $@"
-    	trap "rm -rf ${rmfiles}" EXIT
-}
-
 function	create
 {
-    workdir=`mktemp -p . -d`
-    cleanup "${workdir}"
+    workdir=$(  bfamktemp -p . -d )
     json=$(	solc --optimize --combined-json abi,bin $filename	)
+    test $? eq 0
     prefix=$(	echo "$json"	| jq '.contracts|keys[0]'		)
+    test $? eq 0
     abi=$(	echo "$json"	| jq ".contracts.${prefix}.abi"		)
+    test $? eq 0
     bin=$(	echo "$json"	| jq ".contracts.${prefix}.bin"		)
+    test $? eq 0
+    # Remove all quote marks "
     bin="${bin//\"}"
+    # Save abi for future use
     echo $abi > ${workdir}/abi
+    # We could save the bin, but we don't actually use it later, plus
+    # it gets stored in the blockchain
     #echo $bin > ${workdir}/bin
-    cleanup g1.js
-    cat > g1.js <<EOT
+    js=$(       bfamktemp )
+    cat > $js <<EOT
 var mycontract  = eth.contract(JSON.parse($abi))
 var transaction = mycontract.new( { from: eth.accounts[0], data: "0x${bin}", gas: 1000000 } )
 var rcpt
@@ -47,21 +51,20 @@ var pubcontract = mycontract.at(address);
 console.log( pubcontract.address );
 EOT
     echo '*** Creating contract. Will take 16-30 seconds'
-    cleanup out1
-    geth --datadir network5445/node1 --exec 'loadScript("g1.js")' attach ipc:network5445/node1/geth.ipc > out1
-    if [ ` wc -l < out1 ` = 2 -a `tail -1 < out1` = "true" ]
+    outfile=$(  geth_exec_js $js )
+    if [ ` wc -l < $outfile ` = 2 -a `tail -1 < $outfile` = "true" ]
     then
-        addr=` head -1 < out1 `
-        mkdir network5445/contracts
-        mv ${workdir} network5445/contracts/${addr}
-        echo Your new contract can be found in contracts/${addr}
- 	ln -sf ${addr} network5445/contracts/${contractname}
+        addr=` head -1 < $outfile `
+        mkdir ${network}/contracts
+        mv ${workdir} ${network}/contracts/${addr}
+        echo Your new contract can be found in ${network}/contracts/${addr}
+ 	ln -sf ${addr} ${network}/contracts/${contractname}
     else
-        cat g1.js
+        cat $js
         echo
         echo ' ***'
         echo
-        cat out1
+        cat $outfile
     fi
 }
 

libbfa.sh

+# Probably, this should only be sourced, not executed directly.
+# 20180626 Robert Martin-Legene <robert@nic.ar>
+
+fatal()
+{
+    echo "$@" >&2
+    exit 1
+}
+
+trap "echo Argh! ; exit 1" ERR
+test "$( basename $SHELL 2>/dev/null )" = "bash"		||
+    fatal "This file must be source(d) from bash."
+test "$( caller 2>/dev/null | awk '{print $1}' )" != "0"	||
+    fatal "This file must be source(d), not executed."
+
+function    cleanup
+{
+    if  [ $# -gt 0 ]
+    then
+        trap cleanup EXIT
+        cleanup_files="${cleanup_files} $@"
+        return
+    fi
+    rm  -rf $cleanup_files
+}
+
+# calls mktemp and then cleanup - makes other scripts more compact
+function    bfamktemp
+{
+    local   file=$( mktemp "$@" )
+    cleanup $file
+    echo    $file
+}
+
+function    geth_attach
+{
+    geth    "$@" attach ipc:node1/geth.ipc
+}
+
+function    geth_exec_js
+{
+    test    -r "$1"
+    local   out=$( bfamktemp )
+    geth_attach --exec "loadScript(\"$1\")" > $out
+    echo    $out
+}
+
+function    config_environment
+{
+    creating=0
+    if      [ -z "${networkdir}" ]
+    then
+        local   basedir=$( basename $PWD )
+        if      [ -n "${networkdir}" -a ! -d "${networkdir}" ]
+        then
+            # Networkdir is set and we can't find it. Let's see if
+            # we happen to already be in that directory.
+            if      [ "${basedir}" -ne "${networkdir}" ]
+            then
+                fatal "Your \$networkdir environment variable conflicts with" \
+                    "the name of the directory you are currently in, and I can" \
+                    "not find the networkdir you specified (if any)."
+            fi
+        elif    $( echo "${basedir}" | grep -qE '^network[0-9]+$' )
+        then
+            networkdir="$basedir"
+        fi
+        local   n
+        for     n in $( ls -ld network* 2>/dev/null | grep -qE '^network[0-9]+$' )
+        do
+            if      [ -n "${networkdir}" ]
+            then
+                fatal "If you have more than one work listed in your" \
+                    "current directory, you must specify which one to" \
+                    "use, using the \"networkdir\" environment variable."
+            fi
+            networkdir=${n}
+        done
+        if      [ -z "${networkdir}" ]
+        then
+            echo "I can't find your networkdir."
+            REPLY=
+            while   [ "$REPLY" != "y" -a "$REPLY" != "n" ]
+            do
+                read    -n 1 -p "Would you like me to create a random one for you? [yN]: "
+                if      [ -z "$REPLY" ]
+                then
+                    REPLY=n
+                else
+                    if  [ "${REPLY,,}" = "y" ]
+                    then
+                        creating=1
+                    fi
+                fi
+            done
+            if [ $creating = 1 ]
+            then
+                local   num=0
+                while   [ $num -lt 123456 ]
+                do
+                    num=$(( $RANDOM * $RANDOM ))
+                done
+                networkdir="network${num}"
+                echo "You had no network defined, so I am creating network ${network} for you in ${networkdir}/ ."
+                mkdir "${networkdir}"
+            fi
+        fi
+    fi
+    # set defaults
+    true ${nodedir:=node1}
+    test -n "${nodedir}"
+    if [ ! -d "${nodedir}" -a $creating = 1 ]
+    then
+        mkdir ${networkdir}/${nodedir}
+    else
+        test -d "${nodedir}"
+    fi
+    if [ -z "$account" ]
+    then
+        test -d "${nodedir}/keystore"
+        account=$( ls -1dl "${nodedir}"/keystore/* | head -1 | sed 's/.*--//' )
+    fi
+    test -n "$account"
+}
+
+config_environment